-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VDiff: Comment the VDiffCreate proto msg and set reasonable server side defaults #17026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Oct 22, 2024
mattlord
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
labels
Oct 22, 2024
mattlord
force-pushed
the
vdiff_internal_cleanup
branch
2 times, most recently
from
October 22, 2024 02:24
282ad8d
to
f701b2e
Compare
mattlord
requested review from
ajm188,
notfelineit and
rohit-nayak-ps
as code owners
October 22, 2024 02:24
And enforce sensible defaults on the server side. Signed-off-by: Matt Lord <[email protected]>
mattlord
force-pushed
the
vdiff_internal_cleanup
branch
from
October 22, 2024 02:32
f701b2e
to
6bd4408
Compare
mattlord
changed the title
VDiff: Comment the VDiffCreate proto and set reasonable server side defaults
VDiff: Comment the VDiffCreate proto msg and set reasonable server side defaults
Oct 22, 2024
Signed-off-by: Matt Lord <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17026 +/- ##
=======================================
Coverage 67.15% 67.15%
=======================================
Files 1571 1571
Lines 251836 251840 +4
=======================================
+ Hits 169110 169113 +3
- Misses 82726 82727 +1 ☔ View full report in Codecov by Sentry. |
rohit-nayak-ps
approved these changes
Oct 22, 2024
notfelineit
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is some internal cleanup that I wanted to do after helping some people use the
VtctldServer
VDiff
RPCs directly. It's mostly comments, but it also enforces a couple of additional server side defaults in a sensible way (and which matches the official vtlctld client flag defaults).Related Issue(s)
Checklist