-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Update found rows pool transaction capacity dynamically via vttablet debug/env #17055
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Harshit Gangal <[email protected]>
…ed, changed pool names Signed-off-by: Harshit Gangal <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17055 +/- ##
==========================================
+ Coverage 67.14% 67.15% +0.01%
==========================================
Files 1571 1571
Lines 252060 252125 +65
==========================================
+ Hits 169249 169319 +70
+ Misses 82811 82806 -5 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
Signed-off-by: Harshit Gangal <[email protected]>
@@ -70,90 +70,132 @@ func debugEnvHandler(tsv *TabletServer, w http.ResponseWriter, r *http.Request) | |||
return | |||
} | |||
|
|||
switch r.Method { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks like slightly bigger change set than what is needed for a bugfix. are you sure you are not also doing a big of refactoring here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a single file change. So, refactor should not cause issues.
Looks like a needed change to make it easy for any future changes.
Description
This PR fixes a bug in debug/env to also update both normal and found rows pool of Transaction Pool when modified through /debug/env UI of vttablet.
Related Issue(s)
Checklist
Deployment Notes