Flag for specifying the source tablet type of the binlog player #2822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-berlin
approved these changes
May 5, 2017
|
I can't see a comment... :-) |
| @@ -299,19 +300,24 @@ func (bpc *BinlogPlayerController) Iteration() (err error) { | |||
| return fmt.Errorf("not starting because flag '%v' is set", binlogplayer.BlpFlagDontStart) | |||
| } | |||
|
|
|||
| sourceTabletType, err := topoproto.ParseTabletType(*sourceTabletTypeStr) | |||
| if err != nil { | |||
| log.Fatalf("unknown tablet type: %v", *sourceTabletTypeStr) | |||
There was a problem hiding this comment.
Please use return fmt.Errorf e.g. as in a couple lines above.
We don't want to crash tablets when they're already running.
tirsen
force-pushed
the
binlog-player-source-tablet-flag
branch
from
90c7caf
to
8d6a758
Compare
tirsen
force-pushed
the
binlog-player-source-tablet-flag
branch
from
8d6a758
to
98a7270
Compare
frouioui
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 26, 2024
…ssio#2822) Signed-off-by: Harshit Gangal <[email protected]> Co-authored-by: Harshit Gangal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.