WIP: do not merge. test for order by which is incorrectly planned cross-shard #4542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring by columns of first table, but not if ordering by columns of second table Signed-off-by: deepthi <[email protected]>
|
Do you still need this PR open? |
How do we want to handle this case? If we are fixing it, then we take it out of unsupported_cases once the fix is in, otherwise we take it out of postprocess_cases. |
Signed-off-by: deepthi <[email protected]>
|
Replaced with #4635 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add tests to show that implicit joins with
order bywork fine if ordering by columns of first table, but not if ordering by columns of second tableSigned-off-by: deepthi [email protected]