Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vplayer: add stats tracking and some refactor #4586

Merged
merged 2 commits into from
Feb 17, 2019

Conversation

sougou
Copy link
Contributor

@sougou sougou commented Feb 4, 2019

No description provided.

@sougou
Copy link
Contributor Author

sougou commented Feb 13, 2019

I accidentally pushed lag tracking into this branch, but undid it. So, you can ignore that push notification.

Copy link
Member

@rafael rafael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me. Only follow up question, that we can address in the different PR. I noticed we are not tracking timings when there is a rollback. Wondering if it makes sense to that?

@rafael rafael merged commit 66c45d9 into vitessio:master Feb 17, 2019
@sougou sougou deleted the ss-vrepl branch February 18, 2019 03:35
frouioui added a commit to planetscale/vitess that referenced this pull request Mar 26, 2024
* skip workflows

Signed-off-by: Florent Poinsard <[email protected]>

* fix wrong go version

Signed-off-by: Florent Poinsard <[email protected]>

* re-gen workflows

Signed-off-by: Florent Poinsard <[email protected]>

* Remove old workflows

Signed-off-by: Florent Poinsard <[email protected]>

* Update to checkout@v4

Signed-off-by: Florent Poinsard <[email protected]>

---------

Signed-off-by: Florent Poinsard <[email protected]>
notfelineit pushed a commit to planetscale/vitess that referenced this pull request Apr 13, 2024
vitessio#4794)

* Use paths filtering on more CI workflows (vitessio#4586)

* skip workflows

Signed-off-by: Florent Poinsard <[email protected]>

* fix wrong go version

Signed-off-by: Florent Poinsard <[email protected]>

* re-gen workflows

Signed-off-by: Florent Poinsard <[email protected]>

* Remove old workflows

Signed-off-by: Florent Poinsard <[email protected]>

* Update to checkout@v4

Signed-off-by: Florent Poinsard <[email protected]>

---------

Signed-off-by: Florent Poinsard <[email protected]>

* Re-gen workflows

Signed-off-by: Florent Poinsard <[email protected]>

* Bump actions/setup-go

Signed-off-by: Florent Poinsard <[email protected]>

---------

Signed-off-by: Florent Poinsard <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
Co-authored-by: Florent Poinsard <[email protected]>
systay pushed a commit that referenced this pull request Jul 22, 2024
* skip workflows

Signed-off-by: Florent Poinsard <[email protected]>

* fix wrong go version

Signed-off-by: Florent Poinsard <[email protected]>

* re-gen workflows

Signed-off-by: Florent Poinsard <[email protected]>

* Remove old workflows

Signed-off-by: Florent Poinsard <[email protected]>

* Update to checkout@v4

Signed-off-by: Florent Poinsard <[email protected]>

---------

Signed-off-by: Florent Poinsard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants