-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vplayer: add stats tracking and some refactor #4586
Conversation
I accidentally pushed lag tracking into this branch, but undid it. So, you can ignore that push notification. |
Signed-off-by: Sugu Sougoumarane <[email protected]>
Signed-off-by: Sugu Sougoumarane <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me. Only follow up question, that we can address in the different PR. I noticed we are not tracking timings when there is a rollback. Wondering if it makes sense to that?
* skip workflows Signed-off-by: Florent Poinsard <[email protected]> * fix wrong go version Signed-off-by: Florent Poinsard <[email protected]> * re-gen workflows Signed-off-by: Florent Poinsard <[email protected]> * Remove old workflows Signed-off-by: Florent Poinsard <[email protected]> * Update to checkout@v4 Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]>
vitessio#4794) * Use paths filtering on more CI workflows (vitessio#4586) * skip workflows Signed-off-by: Florent Poinsard <[email protected]> * fix wrong go version Signed-off-by: Florent Poinsard <[email protected]> * re-gen workflows Signed-off-by: Florent Poinsard <[email protected]> * Remove old workflows Signed-off-by: Florent Poinsard <[email protected]> * Update to checkout@v4 Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]> * Re-gen workflows Signed-off-by: Florent Poinsard <[email protected]> * Bump actions/setup-go Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]> Co-authored-by: Florent Poinsard <[email protected]> Co-authored-by: Florent Poinsard <[email protected]>
* skip workflows Signed-off-by: Florent Poinsard <[email protected]> * fix wrong go version Signed-off-by: Florent Poinsard <[email protected]> * re-gen workflows Signed-off-by: Florent Poinsard <[email protected]> * Remove old workflows Signed-off-by: Florent Poinsard <[email protected]> * Update to checkout@v4 Signed-off-by: Florent Poinsard <[email protected]> --------- Signed-off-by: Florent Poinsard <[email protected]>
No description provided.