healthcheck: Cache regions in tablet_stats_cache #4619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Leo Xuzhang Lin <[email protected]>
sougou
reviewed
Feb 13, 2019
|
|
||
| func (tc *TabletStatsCache) getOrCreateRegionByCell(cell string) string { | ||
| // Fast path | ||
| if region, ok := tc.getRegionByCell(cell); ok { |
There was a problem hiding this comment.
No need for a separate fast path. You can just check of tc.cellRegions inside the 'slow' path. It's essentially the same thing. Which means you don't need a separate getRegionByCell function. Which means you could just rename this function to getRegionByCell.
|
Also, there's a new test failure. |
added 2 commits
February 13, 2019 16:44
Signed-off-by: Leo Xuzhang Lin <[email protected]>
Signed-off-by: Leo Xuzhang Lin <[email protected]>
|
I've addressed all comments and fixed the test |
sougou
approved these changes
Feb 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds caches getRegionByCell call to improve initial vtgate healthcheck performance.
We've seen some significant initial healthcheck slow down in our recent vitess upgrade that resulted in the gateway timing out before finishing waiting for the
-tablet_types_to_waitWe were able to diagnose this via a lock contention profile that showed
StatsUpdateto be the pain point. From there @sougou was able to identify the uncached cell region call.Signed-off-by: Leo Xuzhang Lin [email protected]