Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small errors #4626

Merged
merged 1 commit into from
Feb 15, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/Contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ A readability reviewer ensures that the reviewee is writing idiomatic code and f
While there's no Go style guide, there is a set of recommendations in the Go community which add up to an implicit style guide.
To make sure you're writing idiomatic Go code, please read the following documents:

* Go Readablity slides: https://talks.golang.org/2014/readability.slide
* Go Readability slides: https://talks.golang.org/2014/readability.slide
* Talk about Go readability with many specific examples.
* "Effective Go": https://golang.org/doc/effective_go.html
* Recommendations for writing good Go code.
Expand Down
2 changes: 1 addition & 1 deletion doc/DesignDocs.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@ The pages below this navigation entry "Design Docs" represent the design conside
that went behind some of the features implemented. They may not be necessarily up-to-date.

Also, some of the ideas here may just be experimental proposals, and it's possible
that such ideas might have been abandonned or not implemented yet.
that such ideas might have been abandoned or not implemented yet.
2 changes: 1 addition & 1 deletion doc/HorizontalReshardingWorkflowGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ workflow.
A "Retry" button will be enabled under the task node if the task failed (click
the task node if your job get stuck but don't see the Retry button). Click this
button if you have fixed the bugs and want to retry the failed task. You can
retry as many times as you want if the task continuelly failed. The workflow
retry as many times as you want if the task continually failed. The workflow
can continue from your failure point once it is fixed.

For example, you might forget to bring up a vtworker process. The task which
Expand Down
2 changes: 1 addition & 1 deletion doc/SeparatingVttabletMysql.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ The following adjustments need to be made to VTTablet command line parameters:

* Disable restores / backups, by not passing any backup command line
parameters. Specifically, `-restore_from_backup` and
`-backup_storage_implementation` shoud not be set.
`-backup_storage_implementation` should not be set.

Since master management and replication are not handled by Vitess, we just need
to make sure the tablet type in the topology is correct before running
Expand Down
2 changes: 1 addition & 1 deletion doc/Upgrading.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Please use this upgrade order (unless otherwise noted in the release notes):
- vtgate
- application code which links client libraries

*vtctld* is listed first to make sure that you can still adminstrate Vitess - or if not find out as soon as possible.
*vtctld* is listed first to make sure that you can still administrate Vitess - or if not find out as soon as possible.

## Canary Testing

Expand Down
2 changes: 1 addition & 1 deletion go/vt/proto/query/query.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion proto/query.proto
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ message ExecuteOptions {

TransactionIsolation transaction_isolation = 9;

// skip_query_plan_cache specifies if the query plan shoud be cached by vitess.
// skip_query_plan_cache specifies if the query plan should be cached by vitess.
// By default all query plans are cached.
bool skip_query_plan_cache = 10;
}
Expand Down
2 changes: 1 addition & 1 deletion test/initial_sharding.py
Original file line number Diff line number Diff line change
Expand Up @@ -631,7 +631,7 @@ def test_resharding(self):
utils.run_vtctl(['DeleteTablet', '-allow_master',
shard_master.tablet_alias], auto_log=True)

# rebuild the serving graph, all mentions of the old shards shoud be gone
# rebuild the serving graph, all mentions of the old shards should be gone
utils.run_vtctl(['RebuildKeyspaceGraph', 'test_keyspace'], auto_log=True)

# delete the original shard
Expand Down
2 changes: 1 addition & 1 deletion test/legacy_resharding.py
Original file line number Diff line number Diff line change
Expand Up @@ -622,7 +622,7 @@ def test_resharding(self):
utils.run_vtctl(['DeleteTablet', '-allow_master',
shard_1_master.tablet_alias], auto_log=True)

# rebuild the serving graph, all mentions of the old shards shoud be gone
# rebuild the serving graph, all mentions of the old shards should be gone
utils.run_vtctl(
['RebuildKeyspaceGraph', 'test_keyspace'], auto_log=True)

Expand Down
2 changes: 1 addition & 1 deletion test/merge_sharding.py
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ def test_merge_sharding(self):
utils.run_vtctl(['DeleteShard', 'test_keyspace/-40'], auto_log=True)
utils.run_vtctl(['DeleteShard', 'test_keyspace/40-80'], auto_log=True)

# rebuild the serving graph, all mentions of the old shards shoud be gone
# rebuild the serving graph, all mentions of the old shards should be gone
utils.run_vtctl(['RebuildKeyspaceGraph', 'test_keyspace'], auto_log=True)

# kill everything else
Expand Down
2 changes: 1 addition & 1 deletion test/resharding.py
Original file line number Diff line number Diff line change
Expand Up @@ -1214,7 +1214,7 @@ def test_resharding(self):
utils.run_vtctl(['DeleteTablet', '-allow_master',
shard_1_master.tablet_alias], auto_log=True)

# rebuild the serving graph, all mentions of the old shards shoud be gone
# rebuild the serving graph, all mentions of the old shards should be gone
utils.run_vtctl(
['RebuildKeyspaceGraph', 'test_keyspace'], auto_log=True)

Expand Down