Fix some vtctld commands failing to return information to vtctlclient #4647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commands need to log to the wrangler logger so grpcvtctlserver can sent output back over the network instead of just logging locally. Signed-off-by: David Weitzman <[email protected]>
deepthi
approved these changes
Feb 20, 2019
|
Printf will have level "CONSOLE" from https://github.com/vitessio/vitess/blob/master/proto/logutil.proto, as implemented by vitess/go/vt/logutil/logger.go Line 198 in 744b8e2 On the client side, https://github.com/vitessio/vitess/blob/master/go/cmd/vtctlclient/main.go#L57 receives the logutil events and asks logutil to write them to a local console logger |
frouioui
pushed a commit
to planetscale/vitess
that referenced
this pull request
Mar 26, 2024
Signed-off-by: Dirkjan Bussink <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commands need to log to the wrangler logger so grpcvtctlserver can
sent output back over the network instead of just logging locally.
Signed-off-by: David Weitzman [email protected]