vtexplain: properly use sqlparser.String to quote reserved table names #4681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Demmer <[email protected]>
demmer
force-pushed
the
vtexplain-support-escaped-table-names
branch
from
57540c5
to
69f128d
Compare
|
thank you |
|
@sougou review plz. |
sougou
approved these changes
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for vtexplain not working with keyword names for tables such as
action.Details
Previously, vtexplain would return an error such as:
E0226 21:19:04.420743 30715 engine.go:157] Engine.Open: failed to load table action: Row count exceeded 0 (errno 10001) (sqlstate HY000) during query: select * from `action` where 1 != 1The problem was that the schema engine escaped tables when looking up the field signature, but vtexplain didn't do the same.
The fix is simply to consistently use
sqlparser.Stringwhen getting the name of a table.