Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow backup on master #4699

Merged
merged 2 commits into from
Mar 7, 2019
Merged

Conversation

deepthi
Copy link
Member

@deepthi deepthi commented Mar 3, 2019

Fixes #4557, #2903

Allow backup of master with -allow_master flag
BackupShard will still look for a REPLICA/RDONLY/SPARE to use for backups before trying to use master even if -allow_master is set to true

Copy link
Member

@derekperkins derekperkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sougou
Copy link
Contributor

sougou commented Mar 7, 2019

Nice tests :)

@sougou sougou merged commit 8913fcf into vitessio:master Mar 7, 2019
@harshit-gangal harshit-gangal deleted the ds-allow-master-backup branch July 17, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants