vreplication: reference tables #4839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sugu Sougoumarane <[email protected]>
Also make SelectNext more type safe Signed-off-by: Sugu Sougoumarane <[email protected]>
Signed-off-by: Sugu Sougoumarane <[email protected]>
deepthi
approved these changes
Apr 25, 2019
| @@ -104,7 +104,6 @@ func TestRebuildVSchema(t *testing.T) { | |||
| }, | |||
| Tables: map[string]*vschemapb.Table{ | |||
| "table1": { | |||
| Type: "sequence", | |||
There was a problem hiding this comment.
did this actually work earlier? I would have expected it to throw an error.
There was a problem hiding this comment.
It worked earlier, and two users ran into issues when they accidentally deployed sequences on a sharded keyspace. So, I fixed it as part of this change.
| @@ -278,7 +278,9 @@ func (route *Route) StreamExecute(vcursor VCursor, bindVars map[string]*querypb. | |||
| defer cancel() | |||
| } | |||
| switch route.Opcode { | |||
| case SelectUnsharded, SelectScatter: | |||
| case SelectUnsharded, SelectNext, SelectDBA, SelectReference: | |||
There was a problem hiding this comment.
is adding SelectNext and SelectDBA here enabled by vreplication, or is this an incidental change?
There was a problem hiding this comment.
These are essentially unreachable code paths or impractical use cases. But I decided to add these for the sake of correctness and completeness. Otherwise, it becomes hard to reason about why these got left out.
setassociative
added a commit
to tinyspeck/vitess
that referenced
this pull request
Apr 26, 2019
It's been busy and exciting in vitess upstream. Some changes that felt worth calling out as they could impact assumptions about behavior: - vitessio#4832 — this adds a timeout that is 3x the `healthCheckInterval` which at which point the tablet will stop reporting as healthy - vitessio#4814 — this changes when command line args are used by vttablet - vitessio#4811 — a planned reparent now sets `super_read_only` - vitessio#4805 — behavior coming back from a failed backup is different **Slack changes** @demmer vitessio#4827 Correct suppress logging for begin...commit in autocommit @rafael vitessio#4824 adds timeouts for all statements @demmer vitessio#4826 adds logging of stack traces as opt-in @demmer vitessio#4819 remove begin/commit logs from autocommit txns @demmer vitessio#4796 improves support for vtexplain for begin/dml/dml/commit txns **Non slack changes** vitessio#4839 Improve behavior with reference table routing & vreplication vitessio#4833 Support query routing given there could be multiple targets for a table vitessio#4832 tablets get new health check behavior (health checks time out) vitessio#4837 refresh bug around row streamer handling creds vitessio#4830 apply a default value to the db_name attribute in local_metadata vitessio#4785 SHOW SCHEMAS aliased to SHOW DATABASES vitessio#4829 add experimental support for split clone & vertical split clone via vreplication vitessio#4822 do not normalize in order by vitessio#4791 Adds vreplication row streaming support vitessio#4814 command line flags now used regardless of management mode vitessio#4811 vttablet sets super_read_only during planned reparent vitessio#4803 xtrabackup testing vitessio#4727 support multiple vttablets running against one mysql instance vitessio#4746 TopoCat can now produce JSON output vitessio#4805 mysqld is now restarted after a failed backup vitessio#4685 macos bootstrap bug vitessio#4874 ZK opts and java land vitessio#4695 Adds support for xtrabackup vitessio#4794 fixes build failures vitessio#4725 changes mysql8.0 start args vitessio#4736 introduce new states to support vreplication vitessio#4788 expands orc error **Docs etc** vitessio#4831 lint vitessio#4827 docs vitessio#4816 const declaration cleanup vitessio#4820 const declaration cleanup vitessio#4825 docs vitessio#4818 docs vitessio#4809 docs vitessio#4812 moves consts around vitessio#4813 docs vitessio#4808 docs vitessio#4800 docs vitessio#4795 docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference tables are unsharded tables, but are present in a sharded keyspace. They are expected to be present in all shards of a keyspace, and have identical content. Consequently, they do not have vindexes.
You can designate such tables by setting the table type to be
referencein the vschema.Selecting from reference tables will create a new
SelectReferenceplan. This plan will make vtgate pick a random shard to read from. More importantly, when a sharded table is joined with a reference table, it becomes a local join.Typically, reference tables are materialized from an unsharded source through vreplication. You can also specify a routing rule that unifies the source and destination. VTGate will then pick the 'best plan' depending on the query that was issued.