Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better granularity for errors that come out of the transaction pool #5373

Merged
merged 2 commits into from
Nov 23, 2019
Merged

Better granularity for errors that come out of the transaction pool #5373

merged 2 commits into from
Nov 23, 2019

Conversation

rafael
Copy link
Member

@rafael rafael commented Oct 29, 2019 •
edited
Loading

Desc

  • In our on going saga to debug gremlins in outliers timeouts, we've noticed that sometimes we get timeout errors from the connection pool that are due to contexts being already expired when they get to the pool.
  • This PR adds a new error that distinguishes between actual timeouts from the
    pool and errors due to contexts being already expired by the time it gets to
    the pool.

Signed-off-by: Rafael Chacon [email protected]

@rafael
Better granularity for errors that come out of the pool
8a0e96f 
* This PR adds a new error that distinguishes between actual timeouts from the
  pool and errors due to contexts being already expired by the time it gets to
  the pool.

Signed-off-by: Rafael Chacon <[email protected]>
@rafael rafael requested a review from sougou as a code owner October 29, 2019 18:02
@rafael rafael changed the title Better granularity for errors that come out of the pool Better granularity for errors that come out of the transaction pool Oct 29, 2019
@rafael
Update test due to changes
e25bb3c 
Signed-off-by: Rafael Chacon <[email protected]>
@sougou sougou merged commit 65cbfaf into vitessio:master Nov 23, 2019
@rafael rafael mentioned this pull request Dec 11, 2019
Merged
@rafael rafael deleted the txp-pool-error-improvements branch December 11, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sougou sougou sougou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rafael @sougou