Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golangci-lint with linters disabled #5544

Merged
merged 2 commits into from
Dec 11, 2019

Conversation

morgo
Copy link
Contributor

@morgo morgo commented Dec 10, 2019

Part of #5503

I have added the golangci-lint'er but with all the linters that currently produce errors disabled. It will be difficult to enable them all at once, but should be achievable if we target one at a time.

Signed-off-by: Morgan Tocker [email protected]

@morgo morgo requested a review from sougou as a code owner December 10, 2019 17:57
@morgo
Copy link
Contributor Author

morgo commented Dec 10, 2019

Note to reviewers: this does not handle the case yet that a developer needs to rerun the bootstrap (make tools). In general we don't handle the case of developer mistakes currently, and I think that's mostly okay.. since they are a more sophisticated audience.

I changed the implementation. It will also help us get away from bootstrap.sh by downloading inside the hook.

@morgo morgo requested a review from systay December 10, 2019 22:02
This allows bootstrap to eventually be deprecated.

Signed-off-by: Morgan Tocker <[email protected]>
@morgo morgo merged commit d6afb52 into vitessio:master Dec 11, 2019
@morgo morgo deleted the morgo-golangci-lint branch December 11, 2019 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants