Enforce rollback for each connection when shutdown occurs #5659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saif Alharthi <[email protected]>
Signed-off-by: Saif Alharthi <[email protected]>
Signed-off-by: Saif Alharthi <[email protected]>
Signed-off-by: Saif Alharthi <[email protected]>
Signed-off-by: Saif Alharthi <[email protected]>
Signed-off-by: Saif Alharthi <[email protected]>
Signed-off-by: Saif Alharthi <[email protected]>
saifalharthi
changed the title
Signed-off-by: Saif Alharthi <[email protected]>
sougou
reviewed
Jan 14, 2020
| @@ -436,9 +452,17 @@ func shutdownMysqlProtocolAndDrain() { | |||
| } | |||
| } | |||
|
|
|||
| func rollbackAtShutdown() { | |||
There was a problem hiding this comment.
Need to hold mutex here, because you're accessing connections. However, you'll run into a deadlock because ConnectionClosed also obtains the mutex.
I recommend implementing a CloseAllConnections instead of ConnectionClosed, that obtains the mutex and closes all conections in a loop.
And then, you can change servenv.OnClose(rollbackAtShutdown) -> servenv.OnClose(vtgateHandler.CloseAllConnections)
The previous approach we tried led to some race conditions. This new approach of just hard-closing the connection and then wait for the cleanup to happen from that effect feels more stable. Signed-off-by: Sugu Sougoumarane <[email protected]>
Signed-off-by: Sugu Sougoumarane <[email protected]>
sougou
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #5553