Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs Review] Benchmark #1260

Closed
7 tasks done
Tracked by #1222
rsajwani opened this issue Nov 16, 2022 · 3 comments · Fixed by #1263
Closed
7 tasks done
Tracked by #1222

[Docs Review] Benchmark #1260

rsajwani opened this issue Nov 16, 2022 · 3 comments · Fixed by #1263
Assignees
Labels
documentation enhancement New feature or request

Comments

@rsajwani
Copy link
Collaborator

rsajwani commented Nov 16, 2022

Parent Issue #1222
Vitess github url: https://github.com/vitessio/website

Pages to review:

What to do

  • Make sure the content reflect the current state and facts are up-to-date.
  • Add details if needed either in form of new section on current page or adding new page.
  • Add links/Urls on page are working
  • Deprecate flags should be marked as 'deprecated'
  • Review is done for both V15 and V16

Please note that we are not going to focus of restructuring the website content as part of this project. It is something we will do as a separate project later on.

@rsajwani rsajwani changed the title Benchmark [Docs Review] Benchmark Nov 16, 2022
@rsajwani rsajwani added enhancement New feature or request documentation labels Nov 17, 2022
@frouioui
Copy link
Member

Each night, at midnight central european time, the head commit of your pull request will be benchmarked and compared against the pull request's base.

This is wrong, the current CRON for Pull Requests is set to every 5 minutes. We should actually link the CRON tables in the documentation.

@frouioui
Copy link
Member

The rest of the two pages look good to me.

@frouioui
Copy link
Member

@rsajwani, I will open a Pull Request to fix my comment (#1260 (comment)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants