-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 100 shorthand option for pattern based coverage rules #6166
Labels
feat: coverage
Issues and PRs related to the coverage feature
good first issue
Good for newcomers
p2-nice-to-have
Not breaking anything but nice to have (priority)
Comments
thor-juhasz
changed the title
Support 100 coverage for pattern based coverage rules
Support 100 shorthand option for pattern based coverage rules
Jul 18, 2024
AriPerkkio
added
good first issue
Good for newcomers
feat: coverage
Issues and PRs related to the coverage feature
p2-nice-to-have
Not breaking anything but nice to have (priority)
and removed
enhancement: pending triage
labels
Jul 18, 2024
Related code is around here: vitest/packages/vitest/src/utils/coverage.ts Lines 167 to 241 in 807a2cb
|
thor-juhasz
added a commit
to thor-juhasz/vitest
that referenced
this issue
Jul 19, 2024
thor-juhasz
added a commit
to thor-juhasz/vitest
that referenced
this issue
Jul 19, 2024
6 tasks
thor-juhasz
added a commit
to thor-juhasz/vitest
that referenced
this issue
Jul 19, 2024
AriPerkkio
pushed a commit
to thor-juhasz/vitest
that referenced
this issue
Jul 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
feat: coverage
Issues and PRs related to the coverage feature
good first issue
Good for newcomers
p2-nice-to-have
Not breaking anything but nice to have (priority)
Clear and concise description of the problem
As documented here, we can use this:
This I find to be very useful instead of typing out all of the options with the same value.
This is however, not supported for pattern based thresholds, where, I would argue, it becomes even more useful.
Suggested solution
Allow
'100': true
in pattern based coverage tresholds:This reduces clutter far more than only allowing this for the global threshold config.
Alternative
No response
Additional context
No response
Validations
The text was updated successfully, but these errors were encountered: