Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: self/window/global share state with globalThis #1256

Merged
merged 3 commits into from
May 7, 2022
Merged

feat: self/window/global share state with globalThis #1256

merged 3 commits into from
May 7, 2022

Conversation

sheremet-va
Copy link
Member

Fixes #1146

@netlify
Copy link

netlify bot commented May 7, 2022 •
edited
Loading

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 0ecc7bf
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/62766aa4d384c9000890ca51
😎 Deploy Preview https://deploy-preview-1256--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sheremet-va sheremet-va mentioned this pull request May 7, 2022
Closed
6 tasks
@sheremet-va sheremet-va marked this pull request as draft May 7, 2022 11:50
@sheremet-va sheremet-va mentioned this pull request May 7, 2022
Closed
6 tasks
@sheremet-va sheremet-va marked this pull request as ready for review May 7, 2022 12:48
@antfu antfu merged commit fbd7974 into main May 7, 2022
@antfu antfu deleted the feat/globals-share-properties branch May 7, 2022 20:40
chaii3 pushed a commit to chaii3/vitest that referenced this pull request May 13, 2022
@webfansplz
fix(useToggle): toggle function return value (vitest-dev#1256)
8d190ae
@eps1lon eps1lon mentioned this pull request May 17, 2022
Merged
2 tasks
@CodyJasonBennett CodyJasonBennett mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

globalThis is not the same as self when using jsdom
2 participants
@sheremet-va @antfu