Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "fix(vite-node): circular import stuck" #3418 #3479

Merged
merged 3 commits into from
May 31, 2023

Conversation

sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented May 31, 2023

Reverts #3418

mod.importers.has(importee) is always true because we add "importee" to importers a few lines prior

@stackblitz
Copy link

stackblitz bot commented May 31, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@sheremet-va sheremet-va changed the title fix(vite-node): check circular before adding path to importers revert: "fix(vite-node): circular import stuck" vitest-dev#3418 May 31, 2023
@sheremet-va sheremet-va changed the title revert: "fix(vite-node): circular import stuck" vitest-dev#3418 revert: "fix(vite-node): circular import stuck" #3418 May 31, 2023
@antfu
Copy link
Member

antfu commented May 31, 2023

We can do a quick hotfix release if you think it's necessary.

@sheremet-va
Copy link
Member Author

We can do a quick hotfix release if you think it's necessary.

Yes, I think we should do a quick hotfix today when CI passes.

@AriPerkkio
Copy link
Member

The tests in examples/mocks/test/circular.spec.ts should get stuck after this change. Need to revert / skip those ones too.

@sheremet-va sheremet-va merged commit 03d3424 into vitest-dev:main May 31, 2023
@sheremet-va sheremet-va deleted the fix/circular-check branch May 31, 2023 14:18
Dunqing added a commit to Dunqing/vitest that referenced this pull request May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants