Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: testFileDir always matches #4538

Merged
merged 3 commits into from
Nov 27, 2023
Merged

fix: testFileDir always matches #4538

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa1552c
Correspond to the case where the specified file path contains /
ibuibu Nov 19, 2023
51482d5
use path.join
ibuibu Nov 20, 2023
8babbe2
Merge branch 'main' into fix/4425
ibuibu Nov 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/vitest/src/node/workspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,8 @@ export class WorkspaceProject {
return testFiles.filter((t) => {
const testFile = relative(dir, t)
return filters.some((f) => {
return testFile.includes(f) || testFile.includes(relative(dir, f))
const relativePath = f.endsWith('/') ? `${relative(dir, f)}/` : relative(dir, f)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems safer to use the node:path functions then hard coding it like this.

return testFile.includes(f) || testFile.includes(relativePath)
})
})
}
Expand Down
Loading