Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runner): preserve fixtures when calling runif and skipif (fix #4585) #4591

Merged
merged 2 commits into from
Nov 27, 2023
Merged

fix(runner): preserve fixtures when calling runif and skipif (fix #4585) #4591

merged 2 commits into from
Nov 27, 2023

Conversation

dsyddall
Copy link
Contributor

Description

Fixes #4585

Currently, calling test.runIf() and test.skipIf() does not propagate the test's context through the method chain. This causes test fixtures to become unavailable after calling runIf or skipIf. This PR fixes the issue by making the runIf and skipIf functions return the same instance of the test object instead of returning the base test object, preserving the test context.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Nov 26, 2023

Deploy Preview for fastidious-cascaron-4ded94 canceled.

Name Link
🔨 Latest commit 92bdc6f
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65629f76796cc20008afe632

@dsyddall dsyddall changed the title fix(runner): preserve fixtures when calling runif and skipif (fix: #4585) fix(runner): preserve fixtures when calling runif and skipif (fix #4585) Nov 26, 2023
@sheremet-va sheremet-va merged commit 515eadf into vitest-dev:main Nov 27, 2023
15 of 16 checks passed
@dsyddall dsyddall deleted the fix-fixtures-runif-skipif branch November 27, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixtures are not passed to the test function when chained with runIf or skipIf
2 participants