fix(browser): apply inlined workspace config to browser mode vite server #4947
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #4744
For non browser project, inlined workspace project config is included into vite server config via spreading during
initializeProject
:vitest/packages/vitest/src/node/workspace.ts
Lines 42 to 53 in c9824cb
However, browser mode's additional vite server instantiation was missing such logic, which leads to an issue when users relies on root workspace config without dedicated vite/vitest config file for the browser test project.
In this PR, I copied over only(EDIT: I did so in aff160d)test: ...
, but maybe it should spread everything likeinitializeProject
does above since otherwise it would still miss inlined base vite config.Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.