Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run on m1-macos runner #5078

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Jan 30, 2024

Description


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Jan 30, 2024

Deploy Preview for fastidious-cascaron-4ded94 ready!

Name Link
🔨 Latest commit bad92c9
🔍 Latest deploy log https://app.netlify.com/sites/fastidious-cascaron-4ded94/deploys/65d465bb89a999000850f75d
😎 Deploy Preview https://deploy-preview-5078--fastidious-cascaron-4ded94.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va
Copy link
Member

Interesting... By the way, for a long time now I wanted to rewrite our tests to make them faster. I think maybe Vitest workspaces should be faster than spawning Vitest for every pnpm workspace project 🤔

@AriPerkkio
Copy link
Member Author

It could be - at least there would be one process wrapper less. Maybe we should also look into more unified testing approach. At the moment we have quite many ways of running the tests.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@AriPerkkio AriPerkkio marked this pull request as ready for review February 19, 2024 17:10
@sheremet-va sheremet-va merged commit 18a8cdd into vitest-dev:main Feb 20, 2024
18 of 19 checks passed
@AriPerkkio AriPerkkio deleted the ci/mac-m1-runner branch February 20, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants