fix(browser): orchestrator preventing iframe mouse interaction #5813
Conversation
|
Weird behavior when resizing the panel. |
…serquin/fix-browser-iframe-preventing-mouse-events
| pointer-events: none; | ||
| } | ||
| [data-viewport="custom"] { | ||
| padding: 11px; |
There was a problem hiding this comment.
why do you need margins and paddings?
There was a problem hiding this comment.
I intentionally removed all paddings
There was a problem hiding this comment.
It is about the 11px on the left resizer (avoid overlap)
There was a problem hiding this comment.
I can remove both margin and padding, shouldn't be a problem
There was a problem hiding this comment.
There is no overlap, the resizer appears on top of the panel
| @@ -151,7 +151,7 @@ async function createTesters(testFiles: string[]) { | |||
| const container = await getContainer(config) | |||
|
|
|||
| if (config.browser.ui) { | |||
| container.className = '' | |||
| // container.className = '' | |||
There was a problem hiding this comment.
why did you comment that out?
| @@ -151,10 +150,8 @@ async function createTesters(testFiles: string[]) { | |||
| const config = getConfig() | |||
| const container = await getContainer(config) | |||
|
|
|||
| if (config.browser.ui) { | |||
| container.className = '' | |||
| if (config.browser.ui) | |||
| container.textContent = '' | |||
There was a problem hiding this comment.
Why did you remove this? Only the fallback text should be centered
iframe should touch every border
There was a problem hiding this comment.
now it is always centered, the container and the iframe will have the same size
There was a problem hiding this comment.
I've removed also the overflow auto in the container and so centering the content doesn't matter
There was a problem hiding this comment.
the iframe should not be centered
There was a problem hiding this comment.
Can you please explain why you did it and not just state that you did it? I can see the code, I don't see why. The iframe was never meant to be centered
|
There is a lot of changes to styles here that have nothing to do with resizing. The styling works correctly before. Just keep the resizng bug fix please |
Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.