-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ui): add action to explorer item to show the test/suite line in the source code tab #5948
Conversation
Co-authored-by: Anjorin Damilare <[email protected]>
Added code tab and source files to the gz file when running NOTE: codemirror in |
Dont merge yet, I'll change the explorer ítem ui again (missing tooltip when html reporter). |
@userquin Is codemirrorRef guaranteed to be initialized after 256 milliseconds?
|
It is about waiting for route change and 100ms in the onMounted, maybe I can try using another approach to load it. |
Now the logic will focus the line based on the new line router param, forcing the new watcher to trigger in ViewEditor once the new code loaded |
v-if="!isReport" | ||
v-tooltip.bottom="'Run current test'" | ||
data-testid="btn-run-test" | ||
title="Run current test" | ||
icon="i-carbon:play-filled-alt" | ||
text-green5 | ||
:disabled="type !== 'file'" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added disabled run test/suite for future usage: we'll need to change the logic to allow run individual tests/suites.
Sorry if I am late, but could you please clarify why the ability to run individual test was disabled?
Is is something that is coming in the future? Is there a feature request for that or should I open one?
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was never supported. It is possible to support - feel free to create an issue or a PR
Description
Closes #5931
This PR includes:
includeTaskLocation
if running in browser mode (not headless) or ui mode: will preserve user option - @sheremet-va reviewconfig.ts
module 🙏config/index.md
to include previous entryincludeTaskLocation
, the explorer item will show a tooltip similar for coverage without html reporter (check image below): we can just disable the button...navigateTo
tonavigator.ts
composable to allow change the view mode: navigator sfc and explorer item using it, without view mode and with it respectivelyrun
test/suite for future usage: we'll need to change the logic to allow run individual tests/suites.You can see this PR in action in this video.
Disabled includeTaskLocation
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yaml
unless you introduce a new test example.Tests
pnpm test:ci
.Documentation
pnpm run docs
command.Changesets
feat:
,fix:
,perf:
,docs:
, orchore:
.