Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: default pool in the types of 2.0 config #6043

Merged
merged 1 commit into from
Jul 7, 2024
Merged

docs: default pool in the types of 2.0 config #6043

merged 1 commit into from
Jul 7, 2024

Conversation

RobinTail
Copy link
Contributor

@RobinTail RobinTail commented Jul 7, 2024 •
edited
Loading

Description

The default pool was changed to forks in Vitest 2.0:
#5047

But the JSDoc @default was not.
The PR fixes that discrepancy.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@RobinTail RobinTail marked this pull request as ready for review July 7, 2024 11:10
@RobinTail
Copy link
Contributor Author

@AriPerkkio || @sheremet-va , please review

@RobinTail RobinTail changed the title fix: default pool in the types of 2.0 config fix(vitest): default pool in the types of 2.0 config Jul 7, 2024
@AriPerkkio AriPerkkio changed the title fix(vitest): default pool in the types of 2.0 config docs: default pool in the types of 2.0 config Jul 7, 2024
@AriPerkkio AriPerkkio merged commit 5131992 into vitest-dev:main Jul 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AriPerkkio AriPerkkio AriPerkkio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RobinTail @AriPerkkio