Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable CMIS host management on Mellanox-SN4280-O28 SKU #110

Closed
wants to merge 1 commit into from

Conversation

vivekrnv
Copy link
Owner

Why I did it

Enable CMIS host Management feature on SN4280 platform.

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@vivekrnv
Copy link
Owner Author

@noaOrMlnx Can you help with review?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file for ?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the PR which explains why this file is required, https://github.com/sonic-net/sonic-buildimage/pull/19190

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must you add this file ? can't it be linked from other SKU?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the ports are 1-28 instead of 1-32 in other platforms. Last 4 are internal ports for this platform

{
  "GLOBAL_MEDIA_SETTINGS": {
      "1-28": {
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must you add this file ? can't it be linked from other SKU?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@dprital
Copy link

dprital commented Aug 27, 2024

@vivekrnv , Please check that Enable / Disable CMIS Host management works well with cmis_host_mgmt.py script on this system

@vivekrnv
Copy link
Owner Author

@vivekrnv , Please check that Enable / Disable CMIS Host management works well with cmis_host_mgmt.py script on this system

You mean check if this script can enable/disable the CMIS host management properly on SN4280

@vivekrnv vivekrnv closed this Aug 27, 2024
vivekrnv pushed a commit that referenced this pull request Sep 20, 2024
…utomatically (sonic-net#20067)

#### Why I did it
src/sonic-host-services
```
* 052a797 - (HEAD -> 202311, origin/202311) Change dependency option to fix buildimage issue. (#110) (10 hours ago) [Feng-msft]
* 6ab6243 - Fix UT test data due to timestamp break. (sonic-net#117) (10 hours ago) [Feng-msft]
* 7a68e40 - Update ProcessStats query by using API instead of parsing ps command. (#103) (sonic-net#154) (11 hours ago) [mssonicbld]
```
#### How I did it
#### How to verify it
#### Description for the changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants