[plugin-web-app] Add mobile emulation steps #4656

uarlouski · 2023-12-11T08:50:29Z

No description provided.

valfirst · 2023-12-11T08:51:12Z

docs/modules/plugins/pages/plugin-web-app.adoc

@@ -1353,6 +1353,45 @@ Then value `$value` is selected in slider located by `$locator`
 Then value `50` is selected in slider located by `id(test_slider)`
 ----

+=== Emulation steps


Suggested change

=== Emulation steps

=== Mobile Emulation

valfirst · 2023-12-11T08:52:11Z

docs/modules/plugins/pages/plugin-web-app.adoc

+
+==== Override device metrics
+
+Overrides the values of device screen dimensions.


which browsers are supported?
what is an effect of this step execution?

the same for the step clearing metrics

It turns out these steps are supported only on chrome browser, for other browsers:

non-chromium browser like safari: class case exception during augumentation

chromium browsers: Exception in thread "main" org.openqa.selenium.UnsupportedCommandException: unknown command: unknown command: session/6f209346788418b9ce82c8619162e1df/goog/cdp/execute

valfirst · 2023-12-11T08:54:21Z

docs/modules/plugins/pages/plugin-web-app.adoc

+
+[source,gherkin]
+----
+When I override device metrics:`$deviceMetrics`


Suggested change

When I override device metrics:`$deviceMetrics`

When I configure mobile device emulation:`$deviceMetrics`

valfirst · 2023-12-11T08:54:49Z

docs/modules/plugins/pages/plugin-web-app.adoc

+
+[source,gherkin]
+----
+When I clear device metrics


Suggested change

When I clear device metrics

When I clear configuration of mobile device emulation

too cumbersome

valfirst · 2023-12-11T08:54:59Z

vividus-plugin-web-app/src/main/java/org/vividus/steps/ui/web/devtools/EmulationSteps.java

+import org.vividus.selenium.IWebDriverProvider;
+import org.vividus.util.json.JsonUtils;
+
+public class EmulationSteps


Suggested change

public class EmulationSteps

public class MobileEmulationSteps

valfirst · 2023-12-11T08:55:39Z

vividus-plugin-web-app/src/main/java/org/vividus/steps/ui/web/devtools/EmulationSteps.java

+
+    private void executeCdpCommand(String command, Map<String, Object> metrics)
+    {
+        HasCdp hasCdp = webDriverProvider.getUnwrapped(HasCdp.class);


what if this interface is not implemented? what will the error be?

github-actions · 2023-12-11T08:56:36Z

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

codecov · 2023-12-11T08:57:27Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4b450cf) 89.13% compared to head (bf52d02) 97.39%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #4656      +/-   ##
============================================
+ Coverage     89.13%   97.39%   +8.25%     
- Complexity     6778     6782       +4     
============================================
  Files           914      915       +1     
  Lines         18819    18832      +13     
  Branches       1253     1253              
============================================
+ Hits          16774    18341    +1567     
+ Misses         1917      384    -1533     
+ Partials        128      107      -21

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

valfirst · 2023-12-11T14:00:17Z

docs/modules/plugins/pages/plugin-web-app.adoc

+
+==== Emulate mobile device
+
+Emulates mobile device using provided configuration.


Suggested change

Emulates mobile device using provided configuration.

Emulates mobile device using the provided configuration.

valfirst · 2023-12-11T14:00:48Z

docs/modules/plugins/pages/plugin-web-app.adoc

+When I emulate mobile device with configuration:`$deviceMetrics`
+----
+
+* `$deviceMetrics` - The JSON containing device metrics to override, please see https://chromedevtools.github.io/devtools-protocol/tot/Emulation/#method-setDeviceMetricsOverride[available metrics].


Suggested change

* `$deviceMetrics` - The JSON containing device metrics to override, please see https://chromedevtools.github.io/devtools-protocol/tot/Emulation/#method-setDeviceMetricsOverride[available metrics].

* `$deviceMetrics` - The JSON containing https://chromedevtools.github.io/devtools-protocol/tot/Emulation/#method-setDeviceMetricsOverride[device metrics] to override.

valfirst · 2023-12-11T14:01:19Z

docs/modules/plugins/pages/plugin-web-app.adoc

+
+==== Reset mobile device emulation
+
+Resets the mobile device emulation returning browser screen to its initial state.


Suggested change

Resets the mobile device emulation returning browser screen to its initial state.

Resets the mobile device emulation returning the browser to its initial state.

valfirst · 2023-12-11T14:01:44Z

docs/modules/plugins/pages/plugin-web-app.adoc

+When I reset mobile device emulation
+----
+
+.Clears device metrics to default


Suggested change

.Clears device metrics to default

.Resets device metrics to defaults

valfirst · 2023-12-11T14:03:00Z

...dus-plugin-web-app/src/main/java/org/vividus/steps/ui/web/devtools/MobileEmulationSteps.java

+     * Emulates mobile device using provided configuration.
+     *
+     * <p>
+     * <strong>The step is only supported in Chrome browser.</strong>


Suggested change

* <strong>The step is only supported in Chrome browser.</strong>

* <strong>The step is only supported by Chrome browser.</strong>

?

valfirst · 2023-12-11T14:04:45Z

...dus-plugin-web-app/src/main/java/org/vividus/steps/ui/web/devtools/MobileEmulationSteps.java

+    @When("I reset mobile device emulation")
+    public void clearDeviceMetrics()
+    {
+        executeCdpCommand("Emulation.clearDeviceMetricsOverride", Map.of());


what if the browser was started in mobile emulation mode?

it will reset the mobile emulation, even if we have mobile emulation profile activated, technically the initial state of the browser doesn't include mobile emulation, its turned on after the browser is loaded

sonarcloud · 2023-12-12T09:59:54Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

uarlouski requested a review from a team as a code owner December 11, 2023 08:50

uarlouski requested review from valfirst, vkepin and draker94 December 11, 2023 08:50

valfirst requested changes Dec 11, 2023

View reviewed changes

uarlouski force-pushed the feature/mobile-emulation branch 2 times, most recently from acd6de7 to dce419c Compare December 11, 2023 13:56

valfirst requested changes Dec 11, 2023

View reviewed changes

uarlouski force-pushed the feature/mobile-emulation branch 2 times, most recently from df997b6 to c16840b Compare December 11, 2023 15:18

uarlouski mentioned this pull request Dec 11, 2023

Add mobile device emulation feature for playwright #4657

Open

[plugin-web-app] Add mobile emulation steps

bf52d02

valfirst force-pushed the feature/mobile-emulation branch from c16840b to bf52d02 Compare December 12, 2023 09:54

valfirst approved these changes Dec 12, 2023

View reviewed changes

valfirst merged commit 031293b into master Dec 12, 2023
11 checks passed

valfirst deleted the feature/mobile-emulation branch December 12, 2023 11:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[plugin-web-app] Add mobile emulation steps #4656

[plugin-web-app] Add mobile emulation steps #4656

uarlouski commented Dec 11, 2023

valfirst Dec 11, 2023

valfirst Dec 11, 2023

uarlouski Dec 11, 2023

valfirst Dec 11, 2023

valfirst Dec 11, 2023

uarlouski Dec 11, 2023

valfirst Dec 11, 2023

valfirst Dec 11, 2023

github-actions bot commented Dec 11, 2023 •

edited

Loading

codecov bot commented Dec 11, 2023 •

edited

Loading

valfirst Dec 11, 2023

valfirst Dec 11, 2023

valfirst Dec 11, 2023

valfirst Dec 11, 2023

valfirst Dec 11, 2023

valfirst Dec 11, 2023

uarlouski Dec 11, 2023

sonarcloud bot commented Dec 12, 2023


		==== Override device metrics

		Overrides the values of device screen dimensions.

	When I override device metrics:`$deviceMetrics`
	When I configure mobile device emulation:`$deviceMetrics`

	When I clear device metrics
	When I clear configuration of mobile device emulation

	public class EmulationSteps
	public class MobileEmulationSteps


		==== Emulate mobile device

		Emulates mobile device using provided configuration.

	Emulates mobile device using provided configuration.
	Emulates mobile device using the provided configuration.

	* `$deviceMetrics` - The JSON containing device metrics to override, please see https://chromedevtools.github.io/devtools-protocol/tot/Emulation/#method-setDeviceMetricsOverride[available metrics].
	* `$deviceMetrics` - The JSON containing https://chromedevtools.github.io/devtools-protocol/tot/Emulation/#method-setDeviceMetricsOverride[device metrics] to override.


		==== Reset mobile device emulation

		Resets the mobile device emulation returning browser screen to its initial state.

	.Clears device metrics to default
	.Resets device metrics to defaults

	* <strong>The step is only supported in Chrome browser.</strong>
	* <strong>The step is only supported by Chrome browser.</strong>

[plugin-web-app] Add mobile emulation steps #4656

[plugin-web-app] Add mobile emulation steps #4656

Conversation

uarlouski commented Dec 11, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 11, 2023 • edited Loading

Qodana Community for JVM

codecov bot commented Dec 11, 2023 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarcloud bot commented Dec 12, 2023

github-actions bot commented Dec 11, 2023 •

edited

Loading

codecov bot commented Dec 11, 2023 •

edited

Loading