v1.0.0 Release - Introducing TrueHand #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cture for the TrueHand + KinematicHand
…i think i see the end tho - adding more RBs
…gh hands, and is unstable - so onto the next strategy
…rrently trying to integrate dynamic/kinematic RB for the wrists, all bones connect to dynamic RB, then a spring joint from dyn => kin
…ting more to building hands outside of react
…and smoother, problem now is the impulse joints are have much more 'string' than before. Need to fix
… of react, frame rate is consistently 85-90. However, more parts to iron out. todo in Newton Class
…sity in an attempt to improve realism. Almost ready to merge with main
…nges without breaking the current version
…nsors have been added
…ers can only rotate over x-axis. Fingers now stay intact on collision
…ts unvalid due to new hand implmentation
…s, and refactored TrueHandClass
…d reconfigured newtonxr eslint script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Changes
PhysHandhas been replaced byTrueHand.PhysHandwas removed as well as any underlying components and hooks that wassolely utilized by PhysHand.
The decision to replace
PhysHandwithTrueHandwas driven by performanceconsiderations.
PhysHandwas structured to have 24 bones, each being a its ownchild
RigidBodycomponent. This was not the most efficient approach. Toaddress this,
TrueHandis built and updated outside of React, then synced withReact. This approach significantly improves performance by significantly
reducing the overhead within React.
With the Addition addition of
TrueHand, newtonxr will now be focused oncreating the best hand physics possible. It is still early, but it will
continuously get better and better. Making it impertive that you can easily
integrate newtonxr into your project.
Note:
changesetsgets properly integrated