Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.3.5 - Fix breakage from upstream change #51

Merged
merged 1 commit into from
Jun 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ on:
env:
TWINE_PASSWORD: ${{secrets.TWINE_PASSWORD}}
GITHUB_API_TOKEN: ${{secrets.API_TOKEN}}
CODECOV_TOKEN: ${{secrets.CODECOV_TOKEN}}

jobs:
build:
Expand Down Expand Up @@ -55,6 +56,10 @@ jobs:
PY_TEST_EXTRA_ARGS: --cov-report=xml

- uses: codecov/[email protected]
with:
fail_ci_if_error: true
verbose: true
token: ${{secrets.CODECOV_TOKEN}}

- run: mk pypi-upload-ci
env:
Expand All @@ -67,7 +72,7 @@ jobs:

- run: |
mk python-release owner=vkottler \
repo=conntextual version=1.3.4
repo=conntextual version=1.3.5
if: |
matrix.python-version == '3.11'
&& matrix.system == 'ubuntu-latest'
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,11 @@
=====================================
generator=datazen
version=3.1.4
hash=1c09a2d5cb8a5fe2b20a06aef6ff1564
hash=0e2fbdb8a8dcbb003fd2be2072402f40
=====================================
-->

# conntextual ([1.3.4](https://pypi.org/project/conntextual/))
# conntextual ([1.3.5](https://pypi.org/project/conntextual/))

[![python](https://img.shields.io/pypi/pyversions/conntextual.svg)](https://pypi.org/project/conntextual/)
![Build Status](https://github.com/vkottler/conntextual/workflows/Python%20Package/badge.svg)
Expand Down
4 changes: 2 additions & 2 deletions conntextual/__init__.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# =====================================
# generator=datazen
# version=3.1.4
# hash=e87046a2e98422d8d716879f2dbe946f
# hash=8de09ebb47d5fadff586a7eb4d536e01
# =====================================

"""
Expand All @@ -10,4 +10,4 @@

DESCRIPTION = "A network-application TUI using textual."
PKG_NAME = "conntextual"
VERSION = "1.3.4"
VERSION = "1.3.5"
7 changes: 4 additions & 3 deletions conntextual/curses/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,11 @@ async def dispatch(self) -> bool:

# Update state.
self.draw()
window.noutrefresh()
curses.doupdate()

return True
# Not sure what's going on with coverage.
window.noutrefresh() # pragma: nocover
curses.doupdate() # pragma: nocover
return True # pragma: nocover

@property
def cursor(self) -> Cursor:
Expand Down
2 changes: 1 addition & 1 deletion conntextual/curses/tui.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ def draw(self) -> None:
for env_name, env in ENVIRONMENTS.items():
window.addstr(f"========== {env_name} ==========")
window.clrtoeol()
if not self.cursor.inc_y():
if not self.cursor.inc_y(): # pragma: nocover
break

for name in env.env.names:
Expand Down
4 changes: 3 additions & 1 deletion conntextual/ui/footer.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
# third-party
from rich.console import RenderableType
from rich.text import Text
from textual.renderables.blank import Blank
from textual.widgets import Footer


Expand All @@ -25,7 +26,8 @@ def render(self) -> RenderableType:

if self.current_tab:
result = Text.assemble(
result,
# Really dumb.
result if not isinstance(result, Blank) else "",
"| ",
Text(f"tab: {self.current_tab}", style="yellow bold"),
)
Expand Down
2 changes: 1 addition & 1 deletion local/variables/package.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
major: 1
minor: 3
patch: 4
patch: 5
entry: conntextual
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta:__legacy__"

[project]
name = "conntextual"
version = "1.3.4"
version = "1.3.5"
description = "A network-application TUI using textual."
readme = "README.md"
requires-python = ">=3.11"
Expand Down
1 change: 1 addition & 0 deletions tasks/default.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
---