New control frames

[rschell]

PR for Issue #1572.

Here are two new control frames, both using slider controls to adjust the step size or step rate. The first commit adds fixed step size sliders for the Z and XY axes. The second commit adds a continuous control frame using a single slider to adjust the step rate for all three axes. Either or both can replace the current control frame by making the appropriate selection in the bCNC startup files.

No pride of authorship here, take it if you like it, adjust it or I'm happy to make any suggested changes.

Ron

[blayno]

This is the idea i was looking for, well done, how do i install your code ?

[rschell]

This is the idea i was looking for, well done, how do i install your code ?

If you down load the code from my fork rschell/bCNC using the New_Control_Frames branch, you will be using the code that I have been running on my raspberry Pi based machine.

[blayno]

Thank you. I really like the features you have implemented, brilliant work

[bosd]

@rschell Thanks for your work. Could you attend to the codefactor issues?

[rschell]

Happy to, if there is a plan to merge the branch

[bosd]

Just simple GUI test here. Is it on purpose to show all new control frames as default?
On some screens we might run into insufficient screenspace.

[bosd]

Could you remove the extra spaces here. To silence codefactor.

[rschell]

Already fixed in my local version, need to push the change

[bosd]

Testing this code..
Pressing a button in continieus control results in:

Traceback (most recent call last):
  File "D:\Users\user\AppData\Local\Programs\Python\Python310\lib\site-packages\bCNC\Utils.py", line 526, in __call__
    return self.func(*args)
  File "D:\Users\user\AppData\Local\Programs\Python\Python310\lib\site-packages\bCNC\ControlPage.py", line 1985, in jogcancel
    self.app.mcontrol.cjogcancel()
  File "D:\Users\user\AppData\Local\Programs\Python\Python310\lib\site-packages\bCNC\controllers\GRBL1.py", line 49, in cjogcancel
    self.master.serial_write(OV_JOG_CANCEL)
  File "D:\Users\user\AppData\Local\Programs\Python\Python310\lib\site-packages\bCNC\Sender.py", line 479, in serial_write
    ret = self.serial.write(data.encode())
AttributeError: 'NoneType' object has no attribute 'write'

[rschell]

Just simple GUI test here. Is it on purpose to show all new control frames as default? On some screens we might run into insufficient screenspace.

I didn't want to presumptuous that my controls were better so I just added them.

two options.

• One can edit the .bCNC file and adjust the control.page entries to your preference.
• click on the blue titles of the control frames to collapse (minimize) them
  

Been contemplating a more interactive method of selecting the desired frames on the left.

[rschell]

It appears you were not connected to the grbl controller, I get this error too when disconnected. Will look into trapping this condition. It is a more generic issue than the continuous control frame.

Could add to bCNC/Sender.py serial_write routine:

        if self.serial is None:
            print("Serial Write ignored - Not connected to controller")
            return False

[Git-Bruno]

FYI, I had to change spaces to tabs in Sender.py lines 472-474 to get your fork running.

[rschell]

FYI, I had to change spaces to tabs in Sender.py lines 472-474 to get your fork running.

sorry, dealing with two versions one with tabs and one without. Editor defaults to inserting 4 spaces.

[bosd]

FYI the codefactor PR is merged now.
So the version with spaces can be used.