Add jograte and sliders to Control Frame #1749
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to add a default feed rate to the jog function definition, so calls to jog in the abc frame don't need to be modified.
|
rschell
force-pushed
the
Control_sliders
branch
from
ef3d94e
to
2f776f3
Compare
rschell
force-pushed
the
Control_sliders
branch
from
2f776f3
to
03e50e8
Compare
Allow user to specify the jog rate rather than default to the maximum machine jog rate. Values above the maximum machine jog rate will be capped by the controller. Only positive float numbers are allowed. Added Z and XY slider controls to permit easier distance adjustments via a mouse. The sliders have user defined stops along a logarithmic scale. Adjustments by the sliders are reflected in the combobox values. Adjustments via the keyboard +-/* strokes are mirrored in the sliders. The Z distance controls can be linked via the Z combobox XY selection. Changes to be committed: modified: bCNC/ControlPage.py modified: bCNC/bCNC.ini modified: bCNC/controllers/GRBL1.py
Changes to be committed: modified: bCNC/controllers/GRBL1.py modified: bCNC/controllers/_GenericController.py
rschell
force-pushed
the
Control_sliders
branch
from
03e50e8
to
0798a7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt number 3 (squashed, cleaned, triple checked), removed continuous frame from PR (can be submitted in another PR, if requested):
Allow user to specify the jog rate rather than default to the maximum machine jog rate. Values above the maximum machine jog rate will be capped by the controller. Only positive float numbers are allowed, field must always validate to a float number (blank not currently allowed).
Added Z and XY slider controls to permit easier distance adjustments via a mouse. The sliders have user defined stops along a logarithmic scale. Adjustments by the sliders are reflected in the combobox values. Adjustments via the keyboard +-/* strokes are mirrored in the
sliders. The Z distance controls can be linked via the Z combobox XY selection.
Also improved exception handling throughout.
Changes to be committed:
modified: bCNC/ControlPage.py
modified: bCNC/bCNC.ini
modified: bCNC/controllers/GRBL1.py