crypto: add random big integer generation #22266
Open
+63
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spytheman
reviewed
Sep 21, 2024
spytheman
reviewed
Sep 21, 2024
spytheman
reviewed
Sep 21, 2024
spytheman
reviewed
Sep 21, 2024
vlib/crypto/rand/utils.v
Outdated
Comment on lines
68
to
71
| if len == 0 { | ||
| // max must be 0 | ||
| return max | ||
| } |
There was a problem hiding this comment.
That seems weird. Why return a definite number, from a function that is said to return a random one?
There was a problem hiding this comment.
I added a little more explanation in the comment.
If the user-given max is 1, the only valid integer in [0, 1) is 0. So 0 is returned early.
I think allowing users to give 1 as max is ok.
spytheman
reviewed
Sep 21, 2024
spytheman
reviewed
Sep 21, 2024
spytheman
reviewed
Sep 21, 2024
spytheman
reviewed
Sep 21, 2024
|
The vab failure is unrelated, and now fixed on master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #22206