Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetKind/GetDataPtr panics if passed argument is a pointer #4

Open
kirillDanshin opened this issue Nov 18, 2016 · 0 comments
Open

GetKind/GetDataPtr panics if passed argument is a pointer #4

kirillDanshin opened this issue Nov 18, 2016 · 0 comments
Assignees
@vlegio
Labels
bug

Comments

@kirillDanshin
Copy link
Contributor

I propose to add a check that if arg is a pointer then we just convert the pointer to unsafe.Pointer or we take the pointer to convert it otherwise.
For now we just need to document it.
kirillDanshin added a commit to kirillDanshin/efaceconv that referenced this issue Nov 18, 2016
@kirillDanshin
document vlegio#4
e0af620
@kirillDanshin kirillDanshin mentioned this issue Nov 18, 2016
Merged
vlegio pushed a commit that referenced this issue Nov 18, 2016
Merge pull request #5 from kirillDanshin/doc-bug-1
ad34520 
document #4
@vlegio vlegio self-assigned this Nov 21, 2016
@vlegio vlegio added the bug label Nov 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vlegio vlegio

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vlegio @kirillDanshin