Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/BUILD] enable intel queue for longer CPU tests #4113

Merged
merged 25 commits into from
Jun 3, 2024

Conversation

zhouyuan
Copy link
Contributor

@zhouyuan zhouyuan commented Apr 16, 2024

FILL IN THE PR DESCRIPTION HERE

This PR enables intel queue for longer CPU tests. The main changes are

  • fix the bug on pos_encoding kernel
  • enable part of the tests under models
  • skip for tests for cuda only on CPU

related: #3654

BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE


PR Checklist (Click to Expand)

Thank you for your contribution to vLLM! Before submitting the pull request, please ensure the PR meets the following criteria. This helps vLLM maintain the code quality and improve the efficiency of the review process.

PR Title and Classification

Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:

  • [Bugfix] for bug fixes.
  • [CI/Build] for build or continuous integration improvements.
  • [Doc] for documentation fixes and improvements.
  • [Model] for adding a new model or improving an existing model. Model name should appear in the title.
  • [Frontend] For changes on the vLLM frontend (e.g., OpenAI API server, LLM class, etc.)
  • [Kernel] for changes affecting CUDA kernels or other compute kernels.
  • [Core] for changes in the core vLLM logic (e.g., LLMEngine, AsyncLLMEngine, Scheduler, etc.)
  • [Hardware][Vendor] for hardware-specific changes. Vendor name should appear in the prefix (e.g., [Hardware][AMD]).
  • [Misc] for PRs that do not fit the above categories. Please use this sparingly.

Note: If the PR spans more than one category, please include all relevant prefixes.

Code Quality

The PR need to meet the following code quality standards:

  • We adhere to Google Python style guide and Google C++ style guide.
  • Pass all linter checks. Please use format.sh to format your code.
  • The code need to be well-documented to ensure future contributors can easily understand the code.
  • Include sufficient tests to ensure the project to stay correct and robust. This includes both unit tests and integration tests.
  • Please add documentation to docs/source/ if the PR modifies the user-facing behaviors of vLLM. It helps vLLM user understand and utilize the new features or changes.

Notes for Large Changes

Please keep the changes as concise as possible. For major architectural changes (>500 LOC excluding kernel/data/config/test), we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with rfc-required and might not go through the PR.

What to Expect for the Reviews

The goal of the vLLM team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the vLLM team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:

  • After the PR is submitted, the PR will be assigned to a reviewer. Every reviewer will pick up the PRs based on their expertise and availability.
  • After the PR is assigned, the reviewer will provide status update every 2-3 days. If the PR is not reviewed within 7 days, please feel free to ping the reviewer or the vLLM team.
  • After the review, the reviewer will put an action-required label on the PR if there are changes required. The contributor should address the comments and ping the reviewer to re-review the PR.
  • Please respond to all comments within a reasonable time frame. If a comment isn't clear or you disagree with a suggestion, feel free to ask for clarification or discuss the suggestion.

Thank You

Finally, thank you for taking the time to read these guidelines and for your interest in contributing to vLLM. Your contributions make vLLM a great tool for everyone!

@zhouyuan zhouyuan force-pushed the wip_ci_intel_cpu branch 6 times, most recently from 67443ba to 1227a8f Compare April 18, 2024 03:25
@zhouyuan zhouyuan marked this pull request as ready for review April 18, 2024 04:49
tests/models/test_models.py Outdated Show resolved Hide resolved
.buildkite/run-cpu-test.sh Outdated Show resolved Hide resolved
.buildkite/run-cpu-test.sh Outdated Show resolved Hide resolved
.buildkite/run-cpu-test.sh Outdated Show resolved Hide resolved
@zhouyuan zhouyuan requested a review from simon-mo April 19, 2024 05:22
tests/conftest.py Show resolved Hide resolved
tests/conftest.py Show resolved Hide resolved
@zhouyuan zhouyuan force-pushed the wip_ci_intel_cpu branch 6 times, most recently from 733a859 to 743c2e4 Compare May 28, 2024 13:01
@zhouyuan
Copy link
Contributor Author

@simon-mo hi Simon, I made more progress and covered more model tests for CPU backend, please kindly help to check and advise.

thanks
-yuan

Copy link
Collaborator

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me overall pending test_big_models.py to be fixed. If the test suite grow, we can take the same approach as AMD did for mirror_hardwares to run all tests in Intel CPUs.

.buildkite/run-cpu-test.sh Outdated Show resolved Hide resolved
@zhouyuan zhouyuan force-pushed the wip_ci_intel_cpu branch 2 times, most recently from d5f81a5 to f3e300e Compare May 29, 2024 00:41
@@ -19,4 +19,6 @@ RUN VLLM_TARGET_DEVICE=cpu python3 setup.py install

WORKDIR /workspace/

RUN ln -s /workspace/vllm/tests && ln -s /workspace/vllm/examples && ln -s /workspace/vllm/benchmarks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhouyuan
Copy link
Contributor Author

This looks good to me overall pending test_big_models.py to be fixed. If the test suite grow, we can take the same approach as AMD did for mirror_hardwares to run all tests in Intel CPUs.

@simon-mo just fixed the test_big_models.py issue and thanks for the inputs! Will looking into that direction

thanks
-yuan

@simon-mo simon-mo enabled auto-merge (squash) May 29, 2024 04:30
auto-merge was automatically disabled May 29, 2024 23:10

Head branch was pushed to by a user without write access

Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
torch.cuda.is_available() is not working well with multiprocessing case
so we switch to use is_cpu() to check the device

Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
Signed-off-by: Yuan Zhou <[email protected]>
@simon-mo simon-mo merged commit cafb8e0 into vllm-project:main Jun 3, 2024
60 of 65 checks passed
@zhouyuan
Copy link
Contributor Author

zhouyuan commented Jun 3, 2024

@simon-mo thanks a lot for review and merge, will move on to cover more tests on CPU backend.

thanks, -yuan

blinkbear pushed a commit to blinkbear/vllm that referenced this pull request Jun 6, 2024
joerunde pushed a commit to joerunde/vllm that referenced this pull request Jun 17, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jun 27, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 8, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Jul 24, 2024
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants