Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Set label value to timestamp over 0, to keep track of recent history #9777

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

coolkp
Copy link
Contributor

@coolkp coolkp commented Oct 28, 2024

Set label value to timestamp over 0 which is not consumed at all, to keep track of recent history of waiting adapters and active adapters, so metrics polling doesn't have to be aggressive.
We plan to leverage this information for routing decisions in https://github.com/kubernetes-sigs/llm-instance-gateway

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

…of adapter queue and active adapters

Signed-off-by: Kunjan Patel <[email protected]>
@simon-mo simon-mo added the ready ONLY add when PR is ready to merge/full CI is needed label Oct 29, 2024
@simon-mo simon-mo enabled auto-merge (squash) October 29, 2024 17:30
@simon-mo simon-mo merged commit 0ad216f into vllm-project:main Oct 29, 2024
72 checks passed
rasmith pushed a commit to rasmith/vllm that referenced this pull request Oct 30, 2024
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
hissu-hyvarinen pushed a commit to ROCm/vllm that referenced this pull request Nov 6, 2024
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants