[Bugfix] Use host argument to bind to interface #9798
Conversation
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
| @@ -77,7 +77,7 @@ def __call__( | |||
| def make_arg_parser(parser: FlexibleArgumentParser) -> FlexibleArgumentParser: | |||
| parser.add_argument("--host", | |||
| type=nullable_str, | |||
| default=None, | |||
| default="0.0.0.0", | |||
There was a problem hiding this comment.
IMHO this should be set to default="127.0.0.1",. However, this would be a breaking change and should be introduced carefully.
There was a problem hiding this comment.
Thank you for the consideration not breaking compatibility!
| @@ -77,7 +77,7 @@ def __call__( | |||
| def make_arg_parser(parser: FlexibleArgumentParser) -> FlexibleArgumentParser: | |||
| parser.add_argument("--host", | |||
| type=nullable_str, | |||
| default=None, | |||
| default="0.0.0.0", | |||
There was a problem hiding this comment.
Thank you for the consideration not breaking compatibility!
Signed-off-by: Randall Smith <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: NickLucche <[email protected]>
Signed-off-by: Linkun Chen <[email protected]>
…#9798)" (vllm-project#9852) Signed-off-by: Linkun Chen <[email protected]>
Signed-off-by: Loc Huynh <[email protected]>
…#9798)" (vllm-project#9852) Signed-off-by: Loc Huynh <[email protected]>
From what I can gather from the documentation, the
--hostargument is supposed to bind the process to the interface with the IP address provided as the value.This passes the IP address to the
sock.bind()call. To be compatible to the existing behavior, I set the default value forargs.hostto0.0.0.0. However, I think the default value SHOULD be127.0.0.1as missing this setting can result in severe misconfiguration of services.FIX #9797