Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Bugfix] Skip chameleon for transformers 4.46.1 #9808

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

mgoin
Copy link
Collaborator

@mgoin mgoin commented Oct 29, 2024

Chameleon test only specifically checked for 4.46.0, however the newly released 4.46.1 did not address this model

Failing CI https://buildkite.com/vllm/ci-aws/builds/10430#0192d917-3982-44f7-8c97-0a3e2472c7b1/159-4366

Chameleon test only specifically checked for 4.46.0, however the newly released 4.46.1 did not address this model
@mgoin mgoin changed the title Skip chameleon for transformers 4.46.1 [CI][Bugfix] Skip chameleon for transformers 4.46.1 Oct 29, 2024
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Copy link
Collaborator

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞

@simon-mo simon-mo merged commit ab6f981 into main Oct 29, 2024
20 of 23 checks passed
@simon-mo simon-mo deleted the skip-chameleon-transformers-4.46.1 branch October 29, 2024 18:12
@alex-jw-brooks
Copy link
Contributor

Should this be changed in the chameleon model test as well (here)?

rasmith pushed a commit to rasmith/vllm that referenced this pull request Oct 30, 2024
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
NickLucche pushed a commit to NickLucche/vllm that referenced this pull request Oct 31, 2024
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
lk-chen pushed a commit to lk-chen/vllm that referenced this pull request Nov 4, 2024
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants