Fix (potentially) undefined behaviour with std::transform and tolower/toupper #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chaosvex
changed the title
rogical
pushed a commit
to roowow/core
that referenced
this pull request
Nov 2, 2024
…er. (vmangos#2795)" This reverts commit 061b1ef.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pull request
Fixes two potential problems with using tolower/toupper with std::transform. The first being that the argument should be converted explicitly to an unsigned char when used with iterators of type char (std::string) and second being non-addressable functions shouldn't be passed to the standard algorithms (applies to std::*).
Proof
Issues
How2Test
Todo / Checklist