Skip to content
This repository has been archived by the owner on Nov 20, 2020. It is now read-only.

vcloud director usage #2

Closed
nlamirault opened this issue Jan 16, 2015 · 19 comments
Closed

vcloud director usage #2

nlamirault opened this issue Jan 16, 2015 · 19 comments

Comments

@nlamirault
Copy link

It is possible tout use this library with vcloud director ?

@rickard-von-essen
Copy link
Contributor

Currently no. But I have some patches to adapt it to also work with vcloud
director 5.5.

I can try and submit a PR for that next week.
On Jan 16, 2015 6:16 PM, "Nicolas Lamirault" [email protected]
wrote:

It is possible tout use this library with vcloud director ?


Reply to this email directly or view it on GitHub
#2.

@nlamirault
Copy link
Author

great !

@frapposelli
Copy link
Contributor

This project is currently aimed at vCloud Air only (currently supports subscription only but on-demand support is coming) and will focus solely on that.

That said, I have keen interest in having a vCloud Director Go SDK as well so please go ahead with your PR, Ideally I'd like to have a different repo for that but we can discuss it in the PR.

Thanks!

@mattbostock
Copy link

I'd also be interested in a vCloud Director client library in Go as a step towards a vCloud Director plugin for Terraform.

@rickard-von-essen
Copy link
Contributor

You can try my adaptation to VDC 5.5 from this branch:
https://github.com/rickard-von-essen/govcloudair/tree/vcd-5.5
The code is of POC quality, and there is several things I would like to change before submitting a PR. Currently I have a hard time to say when I will have some time rewrite it.

Some of the things I would change is:

  • Merge api*.go
  • Merge the VCDClient, VCAClient and Client types
  • Make all api calls check if they are working on VCD or VCA and handle this transparently from the client of the library.

It would be bad to have to different libraries for VCA and VCD since they are basically the same. If VMWare would opt for that I think there is room for a wrapper lib on top of those uniforming them, but that would be a lot of work for very little value.

I have written a basic Packer VDC builder plugin that show that it is possible to use VCD with packer. The main obstacle to fix before I'll publish is to clean up the above code and to handle setup NAT for SSH into the VM.

@mattbostock I have yet not started to look into a vCloud plugin for Terraform. I will finish the packer plugin first. If you start to work on it be sure to ping me when you start and as soon as you have anything to show and I can contribute to.

@rickard-von-essen
Copy link
Contributor

Also see #1

@frapposelli
Copy link
Contributor

This is very good stuff, thanks @rickard-von-essen !

I don't particularly like the idea of having two separate libraries too, but with the launch of the vCloud Air On Demand service, the API extensions in vCA are more broad in scope than regular vCD API (which is still what lies underneath), I do have some ideas in mind, I will probably open up a proposal for discussion in the next days here on GH.

@nlamirault
Copy link
Author

Great. We would like to use this library to manage our vCloud Director.

@bruceadowns
Copy link

I am also interested in using this (or similar) library to support vcd, onecloud, vcloudair, others. Was there a proposal created to support this use-case as mentioned in previous comments? If so, I would like to review it.

@devopsbrett
Copy link
Contributor

Thanks for the library, I also needed vcd support as I was developing a terraform vcd provider. I merged your work with that of @rickard-von-essen and added some features of my own. I've not opened a pull request as I couldn't guarantee the changes would be compatible with vCloudAir. My version, with changes, can be found here: https://github.com/opencredo/vmware-govcd

@nickithewatt
Copy link
Contributor

@frapposelli just to add to @devopsbrett note above, we can certainly investigate if its worth bringing these changes back in here later, however it seems like vCloudAir and vCD are not guaranteed to stay compatible with each other and may warrant a separate repo anyway

@nickithewatt
Copy link
Contributor

For those that are interested, here is the PR for the terraform-vcd-provider which makes use of the govcd fork hashicorp/terraform#3785. Also please note that the forked repo being used for this PR is now https://github.com/hmrc/vmware-govcd not https://github.com/opencredo/vmware-govcd

@jkinred
Copy link
Contributor

jkinred commented Jan 12, 2016

Has there been any further discussion on this topic?

I'm looking at vCloud Air provisioning with Terraform and have successfully provisioned a vApp with the Terraform vcd provider based on https://github.com/hmrc/vmware-govcd.

With the vcd Terraform provider landing on a public release (0.6.9) it seems like this is going to become more important as people start wanting to contribute upstream.

Is vCloud Air a superset of vCloud Director or will those products diverge too much to have a single library for both?

@frapposelli
Copy link
Contributor

@jkinred vCloud Air is a superset of vCloud Director (at least for now), the library now supports both subscription and on demand APIs, I'm exploring the possibility to have support for plain vCloud Director in the library here, but that is yet to come.

I'm going to plan the roadmap for this and to support the Terraform providers officially, I'll update the thread once we reach a conclusion.

@casualjim
Copy link
Contributor

@jkinred I'm looking at merging that fork into this library and having this library work with both vcloud and vcloudair.

casualjim pushed a commit to casualjim/govcloudair that referenced this issue Feb 12, 2016
@robcoward
Copy link
Contributor

@casualjim how are you getting on with your merge ? If you are still working on it, I'm happy to assist, otherwise I'll take a crack at putting a PR together for a merge.

@frapposelli
Copy link
Contributor

@robcoward we'll work on your PR #29

@robcoward
Copy link
Contributor

Guess that this can be closed by #32

@frapposelli
Copy link
Contributor

Thanks all, vCloud Director support has been merged now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants