ClientState uses a private struct

[wwitzel3]

ClientState is a struct out of internal and makes it non-mockable for testing.

Use an interface to expose this to plugin authors from the service package.

type ClientState interface {
	ClientID() string
	Filters() []Filter
	Namespace() string
	ContextName() string
}

Slack Thread: https://vmware.slack.com/archives/CESL848DN/p1618251260122500

[wwitzel3]

@xtreme-vikram-yadav you mind taking this one?

[wwitzel3]

Something like

var _ service.ClientState = (*clientState)(nil)

type clientState struct {
	clientID    string          `json:"clientID"`
	filters     []octant.Filter `json:"filters"`
	namespace   string          `json:"namespace"`
	contextName string          `json:"contextName"`
}

func (c *clientState) ClientID() string {
	return c.clientID
}
func (c *clientState) Filters() []octant.Filter {
	return c.filters
}
func (c *clientState) Namespace() string {
	return c.namespace
}
func (c *clientState) ContextName() string {
	return c.contextName
}

[wwitzel3]

And then updating tests / imports to deal with any circular deps that shake out and also need to be lifted up.

[xtreme-vikram-yadav]

Sure. Picking this up.