This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
Added properties pane to Resource Viewer #2481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xtreme-vikram-yadav
suggested changes
May 26, 2021
|
@xtreme-vikram-yadav PTAL |
xtreme-vikram-yadav
approved these changes
May 30, 2021
|
Please squash the commits before merging. |
Signed-off-by: Milan Klanjsek <[email protected]>
…ent, restructured replicas, cleaned and refactored code Signed-off-by: Milan Klanjsek <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properties are now displayed for selected node in Resource Viewer:
Properties are created and merged together like this:
VersionandKindare always present at the top. These were already passed down to client, so they are simply just directly added there,Namespace,CreatedandLabels(if present) are added for all resource types,Service Account,NodeandControlled Byfields,IDfield (example how to do that is included for plugin authors),Special notes for your reviewer:
Please let me know if there are certain properties that are better suited for a specific resource. We may need a second pass to tweak what exactly shows up for each resource type.
Signed-off-by: Milan Klanjsek [email protected]