This repository has been archived by the owner on Jan 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ftovaro
force-pushed
the
issue-2304
branch
27 times, most recently
from
May 27, 2021 20:55
a2a7de8
to
5e4d69a
Compare
ftovaro
force-pushed
the
issue-2304
branch
3 times, most recently
from
June 1, 2021 16:49
f016f8a
to
b71bf74
Compare
ftovaro
force-pushed
the
issue-2304
branch
8 times, most recently
from
June 1, 2021 20:42
6fcb5ce
to
a5936da
Compare
mklanjsek
suggested changes
Jun 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, just a few small changes in presentation layer.
web/src/app/modules/shared/components/presentation/tabs-view/tabs-view.component.ts
Outdated
Show resolved
Hide resolved
web/src/app/modules/shared/components/presentation/tabs-view/tabs-view.component.scss
Show resolved
Hide resolved
@ftovaro sorry for late addition, but that button can't touch the tabs in horizontal layout - there needs to be some spacing around |
@mklanjsek Thanks, I was dealing with that and with your comment I solved easily. |
mklanjsek
approved these changes
Jun 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Signed-off-by: ftovaro <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ftovaro [email protected]
What this PR does / why we need it:
Creates tabs component
Which issue(s) this PR fixes
Special notes for your reviewer:
Release note: