Fix route-analyzer not handling equal module basenames

[kepelrs]

Before this commit, the route-analyzer would search for modules by their basenames (eg. my-module.ts). This could match the wrong module in cases where we had two module files with same file name but in different folders.

This change fixes the issue by matching absolute paths instead of only basenames.

Signed-off-by: Davi Barreto [email protected]

PR Checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Examples have been added / updated (for bug fixes / features)
• Changelog has been updated

PR Type

What kind of change does this PR introduce?

• Bugfix

What does this change do?

This change makes the route-analyzer correctly handle duplicate file names by using the absolute path.

What manual testing did you do?

Test new output is unchanged when there are no duplicate module names

a. Run the old route-analyzer locally against VCD master
b. Store the contents of `gen-routes/tenant/app-route.ts` into a separate file
c. Run the newly changed route-analyzer locally against VCD
d. Verify the generated `app-route.ts` file from step a. is strictly equal to step c.

Test the old script breaks when duplicate modules are found

a. checkout vcd_ui master
b. cd content/core
c. Run the following commands to setup a duplicate module with loadChildren:
d.  ng g m z-module --routing
e.  ng g m z-module/catalogs --routing --route catalogs --module=z-module
f. change app.route.tenant.ts line 32, make it point to ZModuleModule
g.  npm run gen-app-routes
h. verify an error is thrown

Test the new script works when duplicate modules are found

a. Perform steps a. through f. from the previous test case
b. Place the fixed route-analyzer under the node_modules folder
c. npm run gen-app-routes
d. verify no error is thrown

Does this PR introduce a breaking change?

• Yes
• No

[juanmendes]

Isn't the ts extension disallowed in imports? The compiler is often looking for .d.ts files or it could even be a JS file? Can you explain in a comment when .ts is present?

[kepelrs]

I got it mixed up with js. You are correct, this never happens... And never will happen. Found this read to be interesting: microsoft/TypeScript#35589

[juanmendes]

Nitpicking since const is preferred

const absolutePath = path.isAbsolute(moduleFolderPath 
   ?  path.join(moduleFolderPath, loadChildrenImportPath) 
   :  path.join(programDirectory, moduleFolderPath, loadChildrenImportPath);

// Must append the file extension, as the TS imports never include it
return `${absolutePath}.ts`;

[juanmendes]

Please add the header and include something that helps the user know what happened instead of a description of the code change.

### [Fixed]
Fixed bug that broke the route-analyzer when two routing modules had the same base name

### Fixed