GitHubIdentityProvider and WebhookAuthenticator should perform tls.Dial with a timeout
#2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pinniped-dev canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2056 +/- ##
==========================================
+ Coverage 31.14% 31.17% +0.02%
==========================================
Files 368 369 +1
Lines 60971 60999 +28
==========================================
+ Hits 18990 19017 +27
- Misses 41456 41457 +1
Partials 525 525
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
joshuatcasey
force-pushed
the
jtc/tls-dial-should-have-timeout
branch
4 times, most recently
from
cd113a7
to
bd897e9
Compare
joshuatcasey
force-pushed
the
jtc/tls-dial-should-have-timeout
branch
2 times, most recently
from
99b6bad
to
e4f1a29
Compare
joshuatcasey
commented
Sep 16, 2024
joshuatcasey
force-pushed
the
jtc/tls-dial-should-have-timeout
branch
from
e4f1a29
to
7e5216c
Compare
joshuatcasey
commented
Sep 19, 2024
internal/controller/authenticator/webhookcachefiller/webhookcachefiller.go
Outdated
Show resolved
Hide resolved
joshuatcasey
force-pushed
the
jtc/tls-dial-should-have-timeout
branch
from
e388a10
to
886ba1b
Compare
internal/controller/supervisorconfig/githubupstreamwatcher/github_upstream_watcher_test.go
Show resolved
Hide resolved
ignore lint error on nil context in unit test validating nil context
joshuatcasey
force-pushed
the
jtc/tls-dial-should-have-timeout
branch
from
3e5b636
to
01c2377
Compare
ashish-amarnath
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHubIdentityProvider and WebhookAuthenticator should perform
tls.Dialwith a timeout.Edit: this should wait on #2057