add --allow-partially-failed flag to velero restore create #1994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Steve Kriss <[email protected]>
skriss
force-pushed
the
restore-allow-partially-failed
branch
from
176a6a8
to
0dab677
Compare
Signed-off-by: Steve Kriss <[email protected]>
carlisia
reviewed
Oct 24, 2019
Signed-off-by: Steve Kriss <[email protected]>
skriss
force-pushed
the
restore-allow-partially-failed
branch
from
3ccda01
to
23e446f
Compare
Signed-off-by: Steve Kriss <[email protected]>
|
this is good to merge then travis passes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Steve Kriss [email protected]
Closes #1858
cc @carlisia @prydonius
I've manually tested this and it works as expected for me - if the new flag is not specified, the most recent completed backup is restored; if it is specified, a more recent PartiallyFailed backup gets selected.
Not convinced this is the right long-term solution but it solves a user pain-point now.