Ensure object store plugin processes are cleaned up after restore and after BSL validation during server start up #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betta1
force-pushed
the
betta1/fix-2039
branch
from
6acf319
to
ade42fc
Compare
|
@betta1 this looks good to me - I'll do some testing today as well. Thanks for the PR! |
skriss
reviewed
Nov 5, 2019
|
FYI, basic testing LGTM - can confirm it fixes the issue, and I didn't encounter any other problems |
|
@carlisia @nrb @prydonius PTAL as well, thanks! |
Signed-off-by: Antony Bett <[email protected]>
…ion during server start up Signed-off-by: Antony Bett <[email protected]>
betta1
force-pushed
the
betta1/fix-2039
branch
from
ade42fc
to
cf80670
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2039