Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use newGR instead of groupResource after apiversion convert #8199

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

AlbeeSo
Copy link
Contributor

@AlbeeSo AlbeeSo commented Sep 10, 2024

Thank you for contributing to Velero!

Please add a summary of your change

When try restore ingresses.extensions in Kubernetes 1.30, restore will be PartiallyFailed as ingresses.extensions is not supported any more. Our plugin try to convert the apiVersion in these cases, which will change the group of the item. So I think groupResource should be replaced by newGR after plugin has finished?

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Created a changelog file or added /kind changelog-not-required as a comment on this pull request.
  • Updated the corresponding documentation in site/content/docs/main.

@AlbeeSo
Copy link
Contributor Author

AlbeeSo commented Sep 10, 2024

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Sep 10, 2024
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 59.23%. Comparing base (49eab81) to head (c2192a7).
Report is 249 commits behind head on main.

Files with missing lines Patch % Lines
pkg/restore/restore.go 50.00% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8199      +/-   ##
==========================================
+ Coverage   58.67%   59.23%   +0.55%     
==========================================
  Files         345      367      +22     
  Lines       28743    30710    +1967     
==========================================
+ Hits        16866    18190    +1324     
- Misses      10448    11065     +617     
- Partials     1429     1455      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blackpiglet blackpiglet added kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes and removed kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes labels Sep 10, 2024
ywk253100
ywk253100 previously approved these changes Sep 10, 2024
Signed-off-by: AlbeeSo <[email protected]>
@shubham-pampattiwar shubham-pampattiwar merged commit da29146 into vmware-tanzu:main Sep 12, 2024
44 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants