Skip uninstall and resource cleanup when fail-fast is enabled. #8216
+394
−256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackpiglet
added
kind/changelog-not-required
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8216 +/- ##
==========================================
- Coverage 59.15% 59.13% -0.02%
==========================================
Files 367 367
Lines 30777 30777
==========================================
- Hits 18206 18200 -6
- Misses 11113 11118 +5
- Partials 1458 1459 +1 ☔ View full report in Codecov by Sentry. |
blackpiglet
force-pushed
the
skip_uninstall_on_fail_fast
branch
from
a9651b3
to
f8a1045
Compare
github-actions
bot
requested review from
anshulahuja98 and
shubham-pampattiwar
reasonerjt
previously approved these changes
Sep 13, 2024
|
@shubham-pampattiwar @kaovilai |
blackpiglet
force-pushed
the
skip_uninstall_on_fail_fast
branch
2 times, most recently
from
25b08cc
to
57175b6
Compare
shubham-pampattiwar
previously approved these changes
Sep 16, 2024
blackpiglet
force-pushed
the
skip_uninstall_on_fail_fast
branch
from
57175b6
to
7a3886b
Compare
reasonerjt
reviewed
Sep 18, 2024
reasonerjt
reviewed
Sep 18, 2024
blackpiglet
force-pushed
the
skip_uninstall_on_fail_fast
branch
from
7a3886b
to
a13f40c
Compare
|
PR is ready. Please take another look. |
reasonerjt
previously approved these changes
Sep 23, 2024
ywk253100
previously approved these changes
Sep 23, 2024
Signed-off-by: Xun Jiang <[email protected]>
blackpiglet
force-pushed
the
skip_uninstall_on_fail_fast
branch
from
a13f40c
to
1ba78b8
Compare
Signed-off-by: Xun Jiang <[email protected]>
blackpiglet
dismissed stale reviews from ywk253100 and reasonerjt
via
5dcb315
kaovilai
approved these changes
Sep 23, 2024
shubham-pampattiwar
approved these changes
Sep 23, 2024
reasonerjt
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.