Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Modify Aggregation process methods (#158)" #172

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

srikartati
Copy link
Contributor

Reverting this commit 7c0a0ae.

Reason is that the PR(antrea-io/antrea#1949) that depends on this commit
is not yet ready. And to move the tag of go-ipfix in Antrea for other
PRs this commit should be present in the latest release tags. Therefore,
reverting this.

Reverting this commit 7c0a0ae.
Reason is the PR(antrea-io/antrea#1949) that depends on this commit
is not yet ready. And to move the tag of go-ipfix in Antrea for other
PRs this commit should be present in the latest release tags. Therefore,
reverting this.
@codecov
Copy link

codecov bot commented Apr 17, 2021

Codecov Report

Merging #172 (5840c4c) into main (a92cedf) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #172      +/-   ##
==========================================
+ Coverage   78.82%   78.88%   +0.06%     
==========================================
  Files          16       16              
  Lines        2021     2008      -13     
==========================================
- Hits         1593     1584       -9     
+ Misses        282      280       -2     
+ Partials      146      144       -2     
Flag Coverage Δ
integration-tests 62.78% <0.00%> (+0.91%) ⬆️
unit-tests 78.32% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/intermediate/aggregate.go 74.37% <100.00%> (-0.40%) ⬇️
pkg/intermediate/worker.go 88.88% <0.00%> (+11.11%) ⬆️

@srikartati
Copy link
Contributor Author

@zyiou Realized that this has to be checked in before we do the release v0.5.0, other wise we cannot move the tag in Antrea.

@srikartati srikartati merged commit 03fc4a4 into vmware:main Apr 19, 2021
@srikartati srikartati deleted the revert_commit branch April 19, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants