Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary allocation in AddInfoElement method #200

Merged
merged 1 commit into from
May 19, 2021

Conversation

srikartati
Copy link
Contributor

This showed up in performance benchmarking through Antrea.
antrea-io/antrea#2188

@codecov
Copy link

codecov bot commented May 18, 2021

Codecov Report

Merging #200 (9c9c34c) into main (c47a31a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #200   +/-   ##
=======================================
  Coverage   78.62%   78.62%           
=======================================
  Files          17       17           
  Lines        2143     2143           
=======================================
  Hits         1685     1685           
  Misses        306      306           
  Partials      152      152           
Flag Coverage Δ
integration-tests 58.47% <ø> (+1.38%) ⬆️
unit-tests 78.28% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/entities/record.go 69.11% <100.00%> (ø)

Copy link
Contributor

@zyiou zyiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this. LGTM

@srikartati srikartati merged commit 604fc6c into vmware:main May 19, 2021
@srikartati srikartati deleted the fix_perf_entities branch May 19, 2021 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants